Extend event_weekly shortcode via "remote_event" and "remote_reason" #29

sixtus · 2022-01-29T21:31:43Z

sixtus commented

2022-01-29 21:31:43 +00:00

Sorry, I stumbled above #26

Did I just catch you copy-pasting code? Seriously?

So I took the liberty to properly include some "remote" option into the existing event_weekly.html.

Some excerpt from the commit messages:

- Not using the term "corona"
  - Too common, and what do we do in the next pandemic? ;)
  - Use the term "remote" and introduce some new "reason" field
- Use the "remote_reason" field to change text dynamically
- Use the existing and "custom.css" style sheets instead of inline css
  - Stick to the color scheme and visual appearance of the theme
  - Allows reusability in future
- Use the proper codepoint notation for the "microbe" emoji
  - Also append "&#xfe0e;" (use the glyph specified in the font, if defined)
    - See "scroll to top" icon in the footer

Sorry, I stumbled above #26 Did I just catch you copy-pasting code? Seriously? So I took the liberty to properly include some "remote" option into the existing `event_weekly.html`. Some excerpt from the commit messages: - Not using the term "corona" - Too common, and what do we do in the next pandemic? ;) - Use the term "remote" and introduce some new "reason" field - Use the "remote_reason" field to change text dynamically - Use the existing and "custom.css" style sheets instead of inline css - Stick to the color scheme and visual appearance of the theme - Allows reusability in future - Use the proper codepoint notation for the "microbe" emoji - Also append "︎" (use the glyph specified in the font, if defined) - See "scroll to top" icon in the footer

👍 1

p1ng0ut was assigned by sixtus

2022-01-29 21:31:43 +00:00

sixtus added 2 commits 2022-01-29 21:31:44 +00:00

12f24a7881 Properly include "remote events" into the common event_weekly shortcode

- Not using the term "corona"
  - Too common, and what do we do in the next pandemic? ;)
  - Use the term "remote" and introduce some new "reason" field
- Use the "remote_reason" field to change text dynamically
- Use the existing and "custom.css" style sheets instead of inline css
  - Stick to the color scheme and visual appearance of the theme
  - Allows reusability in future
- Use the proper codepoint notation for the "microbe" emoji
  - Also append "&#xfe0e;" (use the one specified in the font, if defined)
    - See "scroll to top" icon in the footer

db6e5524fe Display the remote meeting url onto the events overview page(s)

p1ng0ut commented

2022-01-30 14:54:50 +00:00

Hello @sixtus,

thank you for your refactoring. I've done these things on monday and your solution is indeed much better.

Greets,
p1ng0ut

Hello @sixtus, thank you for your refactoring. I've done these things on monday and your solution is indeed much better. Greets, p1ng0ut

p1ng0ut merged commit db6e5524fe into main

2022-01-30 15:11:36 +00:00

p1ng0ut deleted branch remote-event

2022-01-30 15:11:38 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

No Label

No Milestone

No project

No Assignees

2 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Frontend/Homepage#29