From 46230b77eb2c29f0e84e2968179d6d4a3da50e69 Mon Sep 17 00:00:00 2001 From: Tobias Stein Date: Wed, 7 Dec 2022 23:25:18 +0100 Subject: [PATCH] Satisfy ansible-lint truth values --- roles/fai/tasks/apt-cacher-ng.yml | 10 +++++----- roles/fai/tasks/clonezilla.yml | 4 ++-- roles/fai/tasks/fai-ipxe.yml | 8 ++++---- roles/fai/tasks/os.yml | 4 ++-- roles/fai/tasks/tftpd-hpa.yml | 8 ++++---- roles/fai/tasks/time-server.yml | 2 +- 6 files changed, 18 insertions(+), 18 deletions(-) diff --git a/roles/fai/tasks/apt-cacher-ng.yml b/roles/fai/tasks/apt-cacher-ng.yml index 303e3c4..85891e9 100644 --- a/roles/fai/tasks/apt-cacher-ng.yml +++ b/roles/fai/tasks/apt-cacher-ng.yml @@ -1,12 +1,12 @@ - name: "Install apt cacher" - become: True + become: true ansible.builtin.package: name: - apt-cacher-ng state: present - name: "Configure apt cacher" - become: True + become: true ansible.builtin.copy: content: | CacheDir: /var/cache/apt-cacher-ng @@ -42,7 +42,7 @@ notify: restart apt-cacher-ng - name: "Set ubuntu server as backend" - become: True + become: true ansible.builtin.copy: content: | http://archive.ubuntu.com/ubuntu/ @@ -52,14 +52,14 @@ mode: '0644' - name: "Ensure service is started and enabled" - become: True + become: true ansible.builtin.service: name: apt-cacher-ng enabled: true state: started - name: "Set apt cache also for installer host" - become: True + become: true ansible.builtin.copy: dest: "/etc/apt/apt.conf.d/00proxy" content: | diff --git a/roles/fai/tasks/clonezilla.yml b/roles/fai/tasks/clonezilla.yml index 3eb9e75..e3f99c7 100644 --- a/roles/fai/tasks/clonezilla.yml +++ b/roles/fai/tasks/clonezilla.yml @@ -13,7 +13,7 @@ group: root mode: '0755' state: directory - recurse: yes + recurse: true tags: - clonezilla - clonezilla_dir_create @@ -31,7 +31,7 @@ ansible.builtin.shell: chdir: "{{ clonezilla_download_dir }}" cmd: unzip "{{ clonezilla_download_dir + '/' + clonezilla_archive }}" - check_mode: no + check_mode: false tags: - clonezilla - clonezilla_unzip diff --git a/roles/fai/tasks/fai-ipxe.yml b/roles/fai/tasks/fai-ipxe.yml index 0205c02..52433be 100644 --- a/roles/fai/tasks/fai-ipxe.yml +++ b/roles/fai/tasks/fai-ipxe.yml @@ -1,6 +1,6 @@ --- - name: "Install package ipxe" - become: True + become: true ansible.builtin.package: name: ipxe state: present @@ -9,11 +9,11 @@ - ipxe_install - name: "Copy iPXE binaries to '{{ tftp_dir }}'" - become: True + become: true ansible.builtin.copy: src: "{{ item }}" dest: "{{ tftp_dir }}" - remote_src: yes + remote_src: true with_items: - "/usr/lib/ipxe/ipxe.efi" - "/usr/lib/ipxe/ipxe.pxe" @@ -24,7 +24,7 @@ - ipxe_copy - name: "Write ipxe menu" - become: True + become: true ansible.builtin.template: src: "menu.ipxe.j2" dest: "{{ tftp_dir }}/menu.ipxe" diff --git a/roles/fai/tasks/os.yml b/roles/fai/tasks/os.yml index 296b548..c557bab 100644 --- a/roles/fai/tasks/os.yml +++ b/roles/fai/tasks/os.yml @@ -19,7 +19,7 @@ group: root mode: '0440' lstrip_blocks: true - backup: no + backup: false validate: /usr/sbin/visudo -cf %s when: - ansible_nopasswd @@ -65,7 +65,7 @@ package: name: '{{ package_set.core[distrib].standard }}' state: present - update_cache: False + update_cache: false ### ONLY A SET FOR DEBIAN/UBUNTU HAS BEEN DEFINED YET when: ansible_facts['os_family'] == "Debian" tags: diff --git a/roles/fai/tasks/tftpd-hpa.yml b/roles/fai/tasks/tftpd-hpa.yml index 5d2d4d0..7cd5a71 100644 --- a/roles/fai/tasks/tftpd-hpa.yml +++ b/roles/fai/tasks/tftpd-hpa.yml @@ -1,12 +1,12 @@ - name: "Install tftp server" - become: True + become: true ansible.builtin.package: name: - tftpd-hpa state: present - name: "Create tftp fai directory" - become: True + become: true ansible.builtin.file: name: "{{ tftp_dir }}" state: directory @@ -16,7 +16,7 @@ recurse: true - name: "Configure tftp server" - become: True + become: true ansible.builtin.copy: dest: "/etc/default/tftpd-hpa" content: | @@ -30,7 +30,7 @@ notify: restart tftpd - name: "Start tftp daemon" - become: True + become: true ansible.builtin.service: name: tftpd-hpa state: started diff --git a/roles/fai/tasks/time-server.yml b/roles/fai/tasks/time-server.yml index 1b3eace..ea7feba 100644 --- a/roles/fai/tasks/time-server.yml +++ b/roles/fai/tasks/time-server.yml @@ -11,7 +11,7 @@ - name: "Configure rdate for inetd" become: true ansible.builtin.lineinfile: - create: yes + create: true line: 'time stream tcp nowait root internal' dest: "/etc/inetd.conf" owner: root